use apply()

YahooArchive · Jan 5, 2015 · e2d52d6 · Legogris · Feb 22, 2015 · e2d52d6
1 parent 50f2c3a
commit e2d52d6
Show file tree

Hide file tree

Showing 4 changed files with 26 additions and 4 deletions.
diff --git a/lib/History.js b/lib/History.js
@@ -74,7 +74,7 @@ History.prototype = {
     pushState: function (state, title, url) {
         var win = this.win;
         if (this._hasPushState) {
-            win.history.pushState(state, title, url);
+            win.history.pushState.apply(null, arguments);
         } else if (url) {
             win.location.href = url;
         }
@@ -90,7 +90,7 @@ History.prototype = {
     replaceState: function (state, title, url) {
         var win = this.win;
         if (this._hasPushState) {
-            win.history.replaceState(state, title, url);
+            win.history.replaceState.apply(null, arguments);
         } else if (url) {
             win.location.replace(url);
         }

diff --git a/tests/unit/lib/History-test.js b/tests/unit/lib/History-test.js
@@ -194,6 +194,11 @@ describe('History', function () {
         it ('has pushState', function () {
             var history = new History({win: windowMock.HTML5});
 
+            history.pushState({foo: 'bar'});
+            expect(testResult.pushState.state).to.eql({foo: 'bar'});
+            expect(testResult.pushState.title).to.equal(undefined);
+            expect(testResult.pushState.url).to.equal(undefined);
+
             history.pushState({foo: 'bar'}, 't', '/url');
             expect(testResult.pushState.state).to.eql({foo: 'bar'});
             expect(testResult.pushState.title).to.equal('t');
@@ -224,6 +229,12 @@ describe('History', function () {
     describe('replaceState', function () {
         it ('has pushState', function () {
             var history = new History({win: windowMock.HTML5});
+
+            history.replaceState({foo: 'bar'});
+            expect(testResult.replaceState.state).to.eql({foo: 'bar'});
+            expect(testResult.replaceState.title).to.equal(undefined);
+            expect(testResult.replaceState.url).to.equal(undefined);
+
             history.replaceState({foo: 'bar'}, 't', '/url');
             expect(testResult.replaceState.state).to.eql({foo: 'bar'});
             expect(testResult.replaceState.title).to.equal('t');

diff --git a/tests/unit/utils/HistoryWithHash-test.js b/tests/unit/utils/HistoryWithHash-test.js
@@ -223,6 +223,11 @@ describe('HistoryWithHash', function () {
         it ('useHashRoute=false; has pushState', function () {
             var history = new HistoryWithHash({win: windowMock.HTML5});
 
+            history.pushState({foo: 'bar'});
+            expect(testResult.pushState.state).to.eql({foo: 'bar'});
+            expect(testResult.pushState.title).to.equal(undefined);
+            expect(testResult.pushState.url).to.equal(undefined);
+
             history.pushState({foo: 'bar'}, 't', '/url');
             expect(testResult.pushState.state).to.eql({foo: 'bar'});
             expect(testResult.pushState.title).to.equal('t');
@@ -309,6 +314,12 @@ describe('HistoryWithHash', function () {
     describe('replaceState', function () {
         it ('useHashRouter=false; has pushState', function () {
             var history = new HistoryWithHash({win: windowMock.HTML5});
+
+            history.replaceState({foo: 'bar'});
+            expect(testResult.replaceState.state).to.eql({foo: 'bar'});
+            expect(testResult.replaceState.title).to.equal(undefined);
+            expect(testResult.replaceState.url).to.equal(undefined);
+
             history.replaceState({foo: 'bar'}, 't', '/url');
             expect(testResult.replaceState.state).to.eql({foo: 'bar'});
             expect(testResult.replaceState.title).to.equal('t');

diff --git a/utils/HistoryWithHash.js b/utils/HistoryWithHash.js
@@ -135,7 +135,7 @@ HistoryWithHash.prototype = {
             }
         } else {
             if (this._hasPushState) {
-                history.pushState(state, title, url);
+                history.pushState.apply(null, arguments);
             } else if (url) {
                 location.href = url;
             }
@@ -170,7 +170,7 @@ HistoryWithHash.prototype = {
             }
         } else {
             if (this._hasPushState) {
-                history.replaceState(state, title, url);
+                history.replaceState.apply(null, arguments);
             } else if (url) {
                 location.replace(url);
             }