Skip to content
This repository has been archived by the owner on Jul 15, 2019. It is now read-only.

[wip] collaborating on the fluxible-router branch #92

Merged
merged 16 commits into from Apr 21, 2015
Merged

[wip] collaborating on the fluxible-router branch #92

merged 16 commits into from Apr 21, 2015

Conversation

jedireza
Copy link
Contributor

First, apologies on the commit I pushed to the main fluxible-router branch. The rest of my changes to that branch will come as PRs. 😉

@yahoocla
Copy link

CLA is valid!

@jedireza
Copy link
Contributor Author

@mridgway when I commit locally, my pre-commit hook is failing. I reinstalled all deps, am I missing a package?

running pre-commit checks...
running lint: failed!
tests/unit/lib/NavLink-test.js: line 59, col 17, Expected an identifier and instead saw '<'.
tests/unit/lib/NavLink-test.js: line 59, col 18, Expected ')' and instead saw 'MockAppComponent'.
tests/unit/lib/NavLink-test.js: line 59, col 34, Missing semicolon.
tests/unit/lib/NavLink-test.js: line 59, col 44, 'object short notation' is available in ES6 (use esnext option) or Mozilla JS extensions (use moz).
tests/unit/lib/NavLink-test.js: line 60, col 21, Expected an identifier and instead saw '<'.
tests/unit/lib/NavLink-test.js: line 60, col 22, Unrecoverable syntax error. (18% scanned).
...

@@ -53,12 +52,13 @@ var Nav = React.createClass({
</li>
);
});
var context = this.props.context;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't look like this is used any more.

@mridgway mridgway mentioned this pull request Apr 20, 2015
13 tasks
@mridgway
Copy link
Collaborator

jedireza added a commit that referenced this pull request Apr 21, 2015
[wip] collaborating on the fluxible-router branch
@jedireza jedireza merged commit 3e0772a into YahooArchive:fluxible-router Apr 21, 2015
@Vijar Vijar removed the in progress label Apr 21, 2015
@jedireza jedireza deleted the fluxible-router branch April 22, 2015 07:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants