This repository has been archived by the owner on Jul 15, 2019. It is now read-only.
Fix issue with unicode url causing 2 state entries pushed on navigation #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 |
|
CLA is valid! |
lingyan
added a commit
that referenced
this pull request
Sep 2, 2015
Fix issue with unicode url causing 2 state entries pushed on navigation
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mridgway @redonkulus cc:// @pumpikano
This issue was also described in #66.
It is because if you have unicode in the navigate url, History.getUrl() will return encoded string instead of the original url. Therefore failing this url check: https://github.com/yahoo/fluxible-router/blob/228b123bc4f0a22151333a4aab6a6a48e0865c2c/lib/handleHistory.js#L158
This fix will work for modern browsers that support history pushState. For older browsers, we'll leave it as a known issue.