This repository has been archived by the owner on Jul 15, 2019. It is now read-only.
Add handling for pre-render popstate events #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't have a better solution. This looks good to me. 👍 |
|
CLA is valid! |
mridgway
added a commit
that referenced
this pull request
Oct 29, 2015
Add handling for pre-render popstate events
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves an issue where navigation such as
Page 1 -> Page 2 -> Off-siteand then using the back button twice will result in missing the secondpopstateevent. This causes the URL to be forPage 1but still displaying the app onPage 2.Open to other ideas on how to solve this.