This repository has been archived by the owner on Jul 15, 2019. It is now read-only.
Fix rehydrate store for POST routes #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
CLA is valid! |
redonkulus
added a commit
that referenced
this pull request
Nov 9, 2015
Fix rehydrate store for POST routes
|
@andersonba now released in 0.3.2. thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a POST route, the
RouteStorerehydrates the app using the staticGETvalue as method, so, when I'll open a POST url, the server side renders correctly, but in the client side returns 404 (if you don't defined the same route with GET method).Now,
rehydrategets the route method from state (state.currentNavigate.method).I had to check if it exists because in error pages (eg. 404)
currentNavigateisundefined, so, I useGETas default.Added unit test to ensure the behavior.