Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add layout editor #73

Closed
galhavivi opened this issue Jul 15, 2020 · 5 comments
Closed

Add layout editor #73

galhavivi opened this issue Jul 15, 2020 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@galhavivi
Copy link
Member

Add to react-editor the ability to add Item layout and download files.

@galhavivi galhavivi added the enhancement New feature or request label Jul 15, 2020
@galhavivi galhavivi self-assigned this Jul 15, 2020
@WangLarry
Copy link

WangLarry commented Jul 15, 2020

@galhavivi
Layout editor is very cool!

Can not preview layout?

@galhavivi
Copy link
Member Author

@WangLarry Thanks to your excel idea :)
though a future wish is to have sections edited more smoothly like this - https://clippings.github.io/layout-grid/

I deployed it, you can init the forms mock to see a form with data (But it might override your exiting local-storage forms data)
https://yahoo.github.io/jafar/demo-react-editor.html

@galhavivi
Copy link
Member Author

galhavivi commented Jul 15, 2020

@WangLarry
I thought about preview layout... the problem is that a form might have some "custom" needs - like custom components or custom validators, and preview might not work since not all resources for the form exists...
i guess we can add preview with the note that forms with custom resources not be previwed.. but it will be good for people who will use this package a template and adjust to have their custom resources loaded to the preview.. need to think about it

@WangLarry
Copy link

@galhavivi
I have tried to test layout editor.

BTW: another grid layout

@galhavivi
Copy link
Member Author

@WangLarry
Cool ill open a ticket about it... lets see if anyone want to implement it, since its not very urgent :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants