Skip to content
This repository has been archived by the owner on Oct 30, 2018. It is now read-only.

making mojito to work on windows #1103

Merged
merged 14 commits into from May 17, 2013
Merged

making mojito to work on windows #1103

merged 14 commits into from May 17, 2013

Conversation

caridy
Copy link
Contributor

@caridy caridy commented May 8, 2013

Goal

  • To support windows "partially" (which means, all unit tests and basic features tested, but not functional tests)
  • To drop support for nodejs@0.6 because that version does not support windows

    Steps to verify

With this commit very first commit, we get a dummy app working on windows, yay!

npm i mojito -g
mojito create app foo
cd foo
mojito create mojit bar
mojito start

then navigate to http://localhost:8666/@bar/index

TODO

  • Test simple server side app
  • Test simple app with HTMLFrameMojit deployed to the client
  • Test mojito test app . in a simple app
  • Test rpc calls thru the tunnel (common example)
  • Unit tests to pass

@drewfish
Copy link
Contributor

drewfish commented May 8, 2013

I think some RS addons will need similar tweaks too.

@caridy
Copy link
Contributor Author

caridy commented May 8, 2013

Follow-up: windows support is coming: PR #264 #460 #1097 #869 #1063

…d by the store by normalizing the urls using the new util.webpath() method
@ghost ghost assigned caridy May 8, 2013
@caridy
Copy link
Contributor Author

caridy commented May 9, 2013

All unit tests are passing except nodejs 0.6, where some of them are failing:


Consolidated Test Report Summary


Total Number of Executed Tests :672
Total Number of Passed Tests : 647
Total Number of Failed Tests : 13
Total Number of Skipped Tests : 12


List of Failed Test Descriptors


Failed Descriptor Path : /home/travis/build/yahoo/mojito/tests/unit/lib/app/addons/rs/rs_test_descriptor.json
Total Number of Failed Tests : 2

Failed Descriptor Path : /home/travis/build/yahoo/mojito/tests/unit/lib/app/autoload/autoload_test_descriptor.json
Total Number of Failed Tests : 3

Failed Descriptor Path : /home/travis/build/yahoo/mojito/tests/unit/lib/app/commands/commands_test_descriptor.json
Total Number of Failed Tests : 1

Failed Descriptor Path : /home/travis/build/yahoo/mojito/tests/unit/lib/lib_test_descriptor.json
Total Number of Failed Tests : 7

*/

/*jslint node:true, nomen: true */

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this file might need a @module yuidoc section. (If missing I think its methods get added to the module in the previously processed file 😞 .)

@caridy
Copy link
Contributor Author

caridy commented May 16, 2013

All unit tests passed in windows for client and server. If travis is ok with this one, we should merge it.

@caridy
Copy link
Contributor Author

caridy commented May 16, 2013

npm test is not working properly in windows for the mojito repo, apparently related to YahooArchive/arrow/issues/93

@drewfish
Copy link
Contributor

+1

caridy added a commit that referenced this pull request May 17, 2013
closes #264, #460, #1097, #869 and #1063: adding support for windows; dropping support for nodejs 0.6
@caridy caridy merged commit 727475d into YahooArchive:develop May 17, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants