Update: Metric label v2 #1062
Merged
Update: Metric label v2 #1062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
kevinhinterlong
added
the
Visualization
cythrawll
reviewed
Oct 5, 2020
cythrawll
reviewed
Oct 5, 2020
cythrawll
approved these changes
Oct 5, 2020
daniellevinson
approved these changes
Oct 6, 2020
jkusa
reviewed
Oct 6, 2020
packages/core/addon/components/navi-visualization-config/metric-label.ts
Outdated
Show resolved
Hide resolved
packages/core/addon/components/navi-visualizations/metric-label.ts
Outdated
Show resolved
Hide resolved
packages/core/addon/components/navi-visualizations/metric-label.ts
Outdated
Show resolved
Hide resolved
jkusa
approved these changes
Oct 7, 2020
jkusa
pushed a commit
that referenced
this pull request
Nov 2, 2020
* Update: Metric label v2 * Update: Docs fixup * Update: Address pr comments
jkusa
pushed a commit
that referenced
this pull request
Nov 2, 2020
* Update: Metric label v2 * Update: Docs fixup * Update: Address pr comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1002
Description
Updates the metric label visualization for request v2, updates metadata to use cid
Proposed Changes
canonicalNameinhasRequestRunwhere it got a serialized request instead of a request fragmentLicense
I confirm that this contribution is made under an MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.