Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Oak memory leak when closing #7

Closed
yonigottesman opened this issue Nov 4, 2018 · 1 comment
Closed

Oak memory leak when closing #7

yonigottesman opened this issue Nov 4, 2018 · 1 comment
Assignees
@eranmeir @Eshcar @sanastas
Labels
bug Something isn't working

Comments

@yonigottesman
Copy link
Contributor

yonigottesman commented Nov 4, 2018 •
edited
Loading

When a Block is released the "allocated" field is not set back to zero, so once a block is returned it cannot be used again ever. after some oak allocation iterations where no block is free (even if they really are) the jvm throws outofmemory exception.

Fix:
in Block.reset() call allocated.set(0);
@yonigottesman yonigottesman mentioned this issue Nov 4, 2018
Closed
@yonigottesman yonigottesman added the bug Something isn't working label Nov 5, 2018
@yonigottesman
Copy link
Contributor Author

I linked a pr to fix this issue

yonigottesman added a commit to yonigottesman/Oak that referenced this issue Nov 5, 2018
@yonigottesman
[yahoo#7] Fix memory leak. fix code inpection warnings.
c3df5c3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eranmeir eranmeir

@Eshcar Eshcar

@sanastas sanastas

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@eranmeir @yonigottesman @Eshcar @sanastas