Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update grids-core.css #351

Closed
wants to merge 1 commit into from
Closed

Conversation

alexboltunov
Copy link

Flexbox support for modern browsers. Without prefixes.

Flexbox support for modern browsers. Without prefixes.
@ericf
Copy link
Collaborator

ericf commented Jul 10, 2014

@Xlusive have you tested this in the various browsers we support to make sure things work correctly?

I think I recall Firefox adding support for flex-wrap recently…

@alexboltunov
Copy link
Author

Yes, I tested it and its work correctly.

@lkraav
Copy link
Collaborator

lkraav commented Jul 16, 2014

Is there a browser release documentation update about unprefixing etc somewhere?

@ericf
Copy link
Collaborator

ericf commented Aug 20, 2014

@lkraav yeah, on Can I Use: http://caniuse.com/#search=flexbox

@ericf
Copy link
Collaborator

ericf commented Aug 20, 2014

@Xlusive I'm adding this to the 0.6.0 milestone.

@ericf ericf added this to the 0.6.0 milestone Aug 20, 2014
@SelenIT
Copy link

SelenIT commented Sep 10, 2014

Firefox 22 to 27 suported display:flex (unprefixed) and most Flexbox properties, but not flex-wrap and flex-flow. The share of these versions is now negligible and flex-flow is not vital for horizontal only layouts. I suggested a similar update that used 'supports' at-rule to ensure that browser supports all flexbox properties before enabling them, but this at-rule wasn't recognized by CSSlint.

@jamesalley
Copy link
Contributor

I'm on it. I'm going to pull down this branch to double-check everything. If all looks good this will be in 0.6.

@jamesalley
Copy link
Contributor

I'm going to leave grids to a subsequent release. I don't want to touch it right now, as this is not a critical fix and we want to get 0.6 out.

@jamesalley jamesalley removed this from the 0.6.0 milestone Feb 3, 2015
@yahoocla
Copy link

yahoocla commented Feb 3, 2015

CLA is valid!

@jamesalley jamesalley self-assigned this Feb 3, 2015
@stilliard
Copy link

Hi, any updates on this?

@@ -37,6 +37,10 @@
/* IE10 uses display: flexbox */
display: -ms-flexbox;
-ms-flex-flow: row wrap;

/* Modern browsers flexbox */
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be a white-space error here, the comment starts +1 column right

@ifraixedes
Copy link

I had to add myself this to pure 0.6.0, is there any plan to add as a patch?

@wouterhendriks
Copy link

Would be nice if this would be added to Pure

@redonkulus
Copy link
Contributor

Replaced by #617

@redonkulus redonkulus closed this Dec 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants