New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update grids-core.css #351
Conversation
Flexbox support for modern browsers. Without prefixes.
@Xlusive have you tested this in the various browsers we support to make sure things work correctly? I think I recall Firefox adding support for flex-wrap recently… |
Yes, I tested it and its work correctly. |
Is there a browser release documentation update about unprefixing etc somewhere? |
@lkraav yeah, on Can I Use: http://caniuse.com/#search=flexbox |
@Xlusive I'm adding this to the 0.6.0 milestone. |
Firefox 22 to 27 suported display:flex (unprefixed) and most Flexbox properties, but not flex-wrap and flex-flow. The share of these versions is now negligible and flex-flow is not vital for horizontal only layouts. I suggested a similar update that used 'supports' at-rule to ensure that browser supports all flexbox properties before enabling them, but this at-rule wasn't recognized by CSSlint. |
I'm on it. I'm going to pull down this branch to double-check everything. If all looks good this will be in 0.6. |
I'm going to leave grids to a subsequent release. I don't want to touch it right now, as this is not a critical fix and we want to get 0.6 out. |
CLA is valid! |
Hi, any updates on this? |
@@ -37,6 +37,10 @@ | |||
/* IE10 uses display: flexbox */ | |||
display: -ms-flexbox; | |||
-ms-flex-flow: row wrap; | |||
|
|||
/* Modern browsers flexbox */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems to be a white-space error here, the comment starts +1 column right
I had to add myself this to pure 0.6.0, is there any plan to add as a patch? |
Would be nice if this would be added to Pure |
Replaced by #617 |
Flexbox support for modern browsers. Without prefixes.