Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing v2 #160

Closed
kyleboyle opened this issue Sep 11, 2015 · 4 comments
Closed

Testing v2 #160

kyleboyle opened this issue Sep 11, 2015 · 4 comments

Comments

@kyleboyle
Copy link

I am using babel/es6 in my project and am getting an error with 1.2.0:

ERROR in ./~/react-intl/src/react.js
Module parse failed: /node_modules/react-intl/src/react.js Line 7: Unexpected token
You may need an appropriate loader to handle this file type.
| // supports external modules. This is a hack for now that provides the local
| // modules a referece to React.
| export default React;
| 
 @ ./~/react-intl/index.js 6:15-31

Is it possible to test v2 yet? I switched my package.json dep to:

"react-intl": "yahoo/react-intl#v2"

but webpack is now giving me an error when i try to include it:

Module not found: Error: Cannot resolve module 'react-intl'

My /node_modules/react-intl does contain the code from the v2 branch.

@ericf
Copy link
Collaborator

ericf commented Sep 11, 2015

We have a build and you're trying to run the code in src/, clone, build, and link if you want to try before a preview release is on npm.

@ericf ericf closed this as completed Sep 11, 2015
@kyleboyle
Copy link
Author

Ok cool, I have it running now. It seems that all of the child react components of IntlProvider are getting a blank context though. .context is empty but ._reactInternalInstance._context has the intl object. I wonder does this branch require react .14

@ericf
Copy link
Collaborator

ericf commented Sep 11, 2015

See: #162

@kyleboyle
Copy link
Author

thanks for your work on the preview release, everything is working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants