Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate entry on hit Return for suggestion #1275

Closed
3 tasks done
jzohrab opened this issue Jan 8, 2024 · 6 comments
Closed
3 tasks done

Duplicate entry on hit Return for suggestion #1275

jzohrab opened this issue Jan 8, 2024 · 6 comments

Comments

@jzohrab
Copy link
Contributor

jzohrab commented Jan 8, 2024

Prerequisites

  • I am running the latest version
  • I checked the documentation and found no answer
  • I checked to make sure that this issue has not already been filed

Explanation

  • What is the expected behavior?

With a whitelist of suggestions, hitting Return should enter the selected value as a tag only once.

  • What is happening instead?

The selected value is entered twice, and the extra entry is deleted after a short delay. Note this doesn't happen every time, I'm not sure why it occurs at all.

tagify_issue.mov
  • What error message are you getting?

No error, just a dup.

This is not a critical issue! Just looks funny for users. Thank you very much!

@yairEO
Copy link
Owner

yairEO commented Jan 8, 2024

Hi, can you please add steps to reproduce?
I don't understand how to get to this situation

@jzohrab
Copy link
Contributor Author

jzohrab commented Jan 10, 2024

Hi @yairEO -- I can't reproduce it all the time. Basically, I enter the full tag, and then at the end I hit "enter". My tagify settings use a suggestion list, but are not restricted.to the whitelist (user can add new entries).

I'm using the files from the CDN referenced on the README: https://github.com/yairEO/tagify?tab=readme-ov-file#option-1---import-from-cdn -- I downloaded these files and use them locally in my Flask project.

If there is something more up-to-date I should use, let me know.

ps - thank you so much for your responses. Running a free open source project of any time is a real investment of time, and a real contribution. Much appreciated!

@yairEO
Copy link
Owner

yairEO commented Jan 11, 2024

Thanks! Yeah I've invested probably a thousand hours at least for this codebase alone, and I have many other open-source projects as well :) it's very time consuming with no benefits what so ever except satisfaction for helping developers by creating good tools

Without steps-to-reproduce this is going to be difficult to fix.. does this happen often?
I assume more would have complained if it's that big of a bug (which looks like a very annoying bug to me)

@jzohrab
Copy link
Contributor Author

jzohrab commented Jan 13, 2024

It hasn't happened for a while now, so I believe this should be closed. If it happens again, I'll try to collect more useful information. I'll assume it's a user error until proven otherwise.

Re the open-source and satisfaction: I hear you, I'm the same, though not on the scale of tagify. tagify will be helping me out on my project, Lute, a free open-source tool for people to learn languages through reading -- so you'll be having an impact there as well.

I'll close this issue, but perhaps in the meantime you can let me know what attribution is good for tagify. Would an "acknowledgements" page be sufficient for you, with a brief note about your work? Cheers and best wishes! jz

@jzohrab jzohrab closed this as completed Jan 13, 2024
@Biszu
Copy link

Biszu commented Jan 14, 2024

I was facing the same issue. It is caused by a combination of having the whitelist fetched with Ajax and dropdown.hide().

@jzohrab I see that you use Ajax for fetching the whitelist as well, and I assume you do it in a similar manner as the example in README.md (which, unfortunately, is causing issues) — see if not calling dropdown.hide() before making the whitelist request helps.

Kudos to @bdteo for figuring it out in #884

@jzohrab
Copy link
Contributor Author

jzohrab commented Jan 15, 2024

Thank you @Biszu , I changed tagify.loading(true).dropdown.hide() to tagify.loading(true) and this may have addressed the issue. That changed also fixed a very small hiccup: before, I used to have to press the down arrow twice in order to get into the suggestion list; after making the change, I only have to press the down arrow once. A small fix, but still nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants