Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New game screen mod selection broken - my bad #11398

Closed
SomeTroglodyte opened this issue Apr 5, 2024 · 0 comments · Fixed by #11399
Closed

New game screen mod selection broken - my bad #11398

SomeTroglodyte opened this issue Apr 5, 2024 · 0 comments · Fixed by #11399
Labels

Comments

@SomeTroglodyte
Copy link
Collaborator

SomeTroglodyte commented Apr 5, 2024

Game Version

current master from source

Describe the bug

  • Clicking another mod will clear the first checkbox even if no compatibility uniques forbid the combo
  • Started game will not match visible checkboxes
  • Clicking a mod repeatedly will go off-on-off-repeat after fixing the disableChangeEvents blunder

Operating System

Linux

Additional Information

There's one obvious blunder in #11387: deselectIncompatibleMods is meant to turn disableChangeEvents on then off when it's done, but the "off" is a typo
But... When updateSelection is called (it actually shouldn't in this case, but shouldn't hurt either) it seems the Set holding the selected mods is not the same instance that the checkboxes see... Still debugging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant