Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option window cant be closed by clicking out of it #11434

Closed
1 task done
saud2410 opened this issue Apr 9, 2024 · 1 comment · Fixed by #11444
Closed
1 task done

Option window cant be closed by clicking out of it #11434

saud2410 opened this issue Apr 9, 2024 · 1 comment · Fixed by #11444
Labels

Comments

@saud2410
Copy link
Contributor

saud2410 commented Apr 9, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Game Version

4.11.3

Describe the bug

"Never close popups by clicking outside" is revolutionary setting, but option window seems to be the only(afaik) exception. Can't close it when i tap out of it.

Steps to Reproduce

  1. Open Option on main menu or world screen
  2. Check and disable Never close popups by clicking outside setting
  3. Click outside of option popup
  4. See error

Screenshots

image

Link to save file

No response

Operating System

Android

Additional Information

No response

@saud2410 saud2410 added the bug label Apr 9, 2024
@SomeTroglodyte
Copy link
Collaborator

    /** Enables/disables closing by clicking/tapping outside [innerTable].
     *
     *  Automatically set when [addCloseButton] is called but may be changed back or enabled without such a button.
     */
    protected var clickBehindToClose = false

... yes, OptionsPopup does not use the default Popup addCloseButton, so clickBehindToClose defaults to false. I'm pretty sure tat's older than the recent 'move close to a top-right "X"' change... But not 100%.

Good catch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants