Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: getTitle(true) overwrites #465

Open
Tracked by #5
geyst opened this issue Mar 31, 2022 · 1 comment
Open
Tracked by #5

Feature: getTitle(true) overwrites #465

geyst opened this issue Mar 31, 2022 · 1 comment

Comments

@geyst
Copy link

geyst commented Mar 31, 2022

Es wäre praktisch, wenn wir für getTitle() bzw. getTitleTag() einen Parameter mitgeben könnten, um das Schema zu ignorieren oder zu ändern.

Anwendungsfall

Für Home möchte ich ein anderes Schema verwenden, bzw. das Schema ignorieren.

Anwendung

// title
$seo->getTitle(true); // kein Schema
$seo->getTitle('%T -> %SN'); // neues Schema

// title tag
$seo->getTitleTag(false); // kein Schema
$seo->getTitleTag('%T -> %SN'); // neues Schema

Code (ungetestet)

public function getTitle($title_schema_overwrite = false)
    {
        $title_scheme = htmlspecialchars_decode(trim($this->domain->getTitle()));
        if ('' == $title_scheme && !$title_schema_overwrite) {
            $title_scheme = self::$title_scheme_default;
        }
        elseif($title_schema_overwrite) {
        	if(gettype($title_schema_overwrite) == 'string') {
        		$title_scheme = $title_schema_overwrite; // overwrite with new schema
			}
        	elseif(gettype($title_schema_overwrite) == 'boolean') {
				$title_scheme = ''; // overwrite with empty schema
			}
		}

        $ytitle = '';
        if ($this->article && '' != $this->article->getValue(self::$meta_title_field)) {
            $ytitle = $this->article->getValue(self::$meta_title_field);
        }
        if ('' == $ytitle) {
            $ytitle = $this->article->getValue('name');
        }

        $title = $title_scheme;
        $title = str_replace('%T', $ytitle, $title);
        $title = str_replace('%SN', rex::getServerName(), $title);

        return $this->cleanString($title);
    }
@alxndr-w
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants