Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight.js 9.0 is outdated, the package is broken right now #62

Closed
lokapal opened this issue Jan 6, 2021 · 2 comments
Closed

Highlight.js 9.0 is outdated, the package is broken right now #62

lokapal opened this issue Jan 6, 2021 · 2 comments
Assignees

Comments

@lokapal
Copy link

lokapal commented Jan 6, 2021

gwtc ./nwchem.wiki
Version 9 of Highlight.js has reached EOL and is no longer supported.
Please upgrade or ask whatever dependency you are using to upgrade.
highlightjs/highlight.js#2877
documentation.html

I've tried npm install highlight.js and it says, that 10.5 version is installed. GWTC, obviously, use its own highlight.js

@panvicka
Copy link

Hello, until fixed I have cloned the repo, changed line 64 in package.json to "highlight.js": "^10.0," and installed it as local version as described in README https://github.com/yakivmospan/github-wikito-converter#local-version

It runs ok again.

"dependencies": {
"bluebird": "^2.9.34",
"bootstrap": "^3.3.7",
"commander": "^2.8.1",
"datauri": "^1.0.5",
"defaults": "^1.0.2",
"fs-extra": "^0.23.1",
"highlight.js": "^9.12.0",
"jquery": "^2.1.4",
"marked": "^0.3.6",
"node-dir": "^0.1.9",
"open": "0.0.5",
"winston": "^1.0.1",
"wkhtmltopdf": "^0.1.5"
},

@yakivmospan yakivmospan self-assigned this Jan 23, 2021
@yakivmospan
Copy link
Owner

yakivmospan commented Apr 25, 2021

Fixed in release 1.5.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants