Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appcompat lib no necessary #22

Closed
start141 opened this issue Feb 3, 2016 · 3 comments
Closed

Appcompat lib no necessary #22

start141 opened this issue Feb 3, 2016 · 3 comments

Comments

@start141
Copy link
Contributor

start141 commented Feb 3, 2016

Thanks for a nice library!

uCrop extend AppCompatActivity, I think it is no necessary.
Can you use custom layout instead ActionBar and remove the appcompat lib? It will let the library smaller.
If you agree, I will pull a request.

Thanks again!

@shliama
Copy link
Contributor

shliama commented Feb 3, 2016

Are there any apps that do not use appcompat lib? Well - they should :)
What about appcompat theme?

@start141
Copy link
Contributor Author

start141 commented Feb 3, 2016

Some apps use holo/material theme.

@timkoers
Copy link
Contributor

@start141 The AppCompat Lib makes sure that the result of various methods is exactly the same on all of the Android API platforms. Without this lib, coding an library that looks the same on every api version is very hard.

You should use this lib yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants