Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Http/Https as uri source not supported #42

Closed
gromiloff opened this issue Feb 25, 2016 · 6 comments
Closed

Http/Https as uri source not supported #42

gromiloff opened this issue Feb 25, 2016 · 6 comments

Comments

@gromiloff
Copy link

By code I can see what only file uri supported as source for launch library.
If try to set uri as link to image - get exeption java.io.FileNotFoundException: No content provider

It's because BitmapLoadUtils.decode use only one provider, which try to open existing file on read:
context.getContentResolver().openFileDescriptor(uri, "r")

So, I think need include functionality for support another uri types.

@shliama
Copy link
Contributor

shliama commented Feb 27, 2016

Yes it's not supported nowadays. Sure it's a good feature but I can't give you any estimates. Any contribution is welcome :octocat:

@JohnWowUs
Copy link
Contributor

What's the use case for this feature? Is there really a scenario where you want to crop a remote image?

@gromiloff
Copy link
Author

@JohnWowUs the question is in correct logic.
If you want crop remite image and no need save tmp file before crop and remove after, then this is your requested scenario.

For example, I want set avatar from facebook album. I have the url of image. So, now I must save tmp image to fs, crop, remove tmp image.
But I no need saving operations in app logic.
Lib may do it self.

How would it implement - the question to lib owner. :)

@shliama
Copy link
Contributor

shliama commented Mar 21, 2016

I won't say that we'll never implement this feature, but it definitely doesn't have top priority at the moment. Currently top priority feature is performance and high-resolution image processing via native code.

@gromiloff
Copy link
Author

it's not high issue)

@shliama
Copy link
Contributor

shliama commented Apr 8, 2016

Http/Https Uri support was added in 1.4.0 :octocat:

@shliama shliama closed this as completed Apr 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants