Skip to content
This repository has been archived by the owner on Jul 24, 2020. It is now read-only.

Error Reporting - Date out of range #21

Closed
caseywatts opened this issue May 29, 2012 · 7 comments
Closed

Error Reporting - Date out of range #21

caseywatts opened this issue May 29, 2012 · 7 comments
Labels
Milestone

Comments

@caseywatts
Copy link
Collaborator

caseywatts commented May 29, 2012

When I try to update dates on a reservation and I choose illegal dates (like February 30th) it gives the

"We're sorry, but something went wrong.
We've been notified about this issue and we'll take a look at it shortly."

error, instead of something more helpful. Any chance we can fix that?

If it could say something like "Invalid date range" instead of just the generic error message, THAT would be immensely helpful.

@tchaicowsky
Copy link

Update: Now instead of giving a "We're sorry, something went wrong" message, the app just breaks:

ArgumentError in ApplicationController#update_cart
invalid date

@caseywatts
Copy link
Collaborator Author

The "we're sorry, something went wrong" happens on the production server, life, as a prettier frontent. The ArgumentError... is ugly but informational for our development server. Same problem!
I think validations would do the trick~!

@ghost ghost assigned ebmaher Jun 8, 2012
@ebmaher
Copy link
Contributor

ebmaher commented Jun 13, 2012

with the new version of date searches (calendar! yay!) this shouldn't ever be a problem. closing issue.

@ebmaher ebmaher closed this as completed Jun 13, 2012
@caseywatts
Copy link
Collaborator Author

Even if we try to break it? :O

@ebmaher ebmaher reopened this Jun 20, 2012
@ebmaher
Copy link
Contributor

ebmaher commented Jun 20, 2012

womp. this can be broken. working on it

@dgoerger
Copy link
Contributor

datepicker successfully prevents the input of invalid dates. tested with 06/31/2012 and 02/29/2013. resolving.

@adambray adambray reopened this Nov 5, 2012
@adambray
Copy link
Contributor

adambray commented Nov 5, 2012

You can still enter invalid dates by hand, and the update_cart method will throw an ArguementError: invalid date silently.

We should have error messages displayed in this case.

@ghost ghost assigned ebmaher Nov 5, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants