Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct class name in ColorPicker #1483

Closed
3 tasks
illionillion opened this issue May 10, 2024 · 2 comments
Closed
3 tasks

Correct class name in ColorPicker #1483

illionillion opened this issue May 10, 2024 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers
Milestone

Comments

@illionillion
Copy link
Member

illionillion commented May 10, 2024

Which package has an issue?

@yamada-ui/react

Package Version

1.3.9

Description

Corrected the following class names according to BEM

  • ui-color-picker__eye-dropper__icon
    • fix to ui-color-picker__eye-dropper-icon
  • ui-color-selector__eye-dropper__icon
    • fix to ui-color-selector__eye-dropper-icon
  • ui-color-selector__swatches__label
    • fix to ui-color-selector__swatches-label

Create the changeset with major.
Please derive a new branch from the v2.0 branch and create a pull request for the v2.0 branch, not the main branch, as we plan to release the product in v2.0.0.

Link to Reproduction

No response

Steps to Reproduce

  1. Go to '...'
  2. Click on '...'
  3. Scroll down to '...'
  4. See error

Browser

None

Operating System

  • macOS
  • Windows
  • Linux

Do you know how to fix the issue?

None

Are you willing to participate in fixing this issue and create a pull request with the fix?

None

Additional Information

No response

@illionillion illionillion added bug Something isn't working good first issue Good for newcomers labels May 10, 2024
@illionillion illionillion added this to the v2.0 milestone May 10, 2024
@illionillion
Copy link
Member Author

Fix the test code if necessary.

@illionillion
Copy link
Member Author

This Issue is Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant