Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using dot-writer library #9

Closed
DrGabble opened this issue Jul 1, 2021 · 0 comments
Closed

Using dot-writer library #9

DrGabble opened this issue Jul 1, 2021 · 0 comments

Comments

@DrGabble
Copy link

DrGabble commented Jul 1, 2021

Would you be averse to me refactoring your graphviz code to use my new dot-writer library? Largely for my own selfish reasons (so I can put it through its paces and put it out in the world a bit), but arguably it could make your code more readable, strongly typed and terser?

Happy to do the pull request myself of course (I might have to anyway as it might be missing a function here or there that your dot output needs), and equally understand if you'd like to minimize dependancies / leave things as they are.
Repository owner locked and limited conversation to collaborators Jul 1, 2021

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yamafaktory @DrGabble