Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable NULL label in orderInput() #63

Closed
tomicapretto opened this issue Mar 23, 2020 · 1 comment
Closed

Enable NULL label in orderInput() #63

tomicapretto opened this issue Mar 23, 2020 · 1 comment

Comments

@tomicapretto
Copy link

When you specify a NULL label in, for example, selectInput(), the result is an input object without header.
The current implementation of orderInput() lets the user to specify a NULL label but it does not result in the label being removed and consequently you get a blank space in the UI.

Currently, orderInput() handles the label argument as follows:

...
  label <- shiny::tags$label(label, `for` = inputId)
...

I think that you can switch it to

...
  if (!is.null(label)) label <- shiny::tags$label(label, `for` = inputId)
...

In order to behave similarly to other input functions in shiny.

@Yang-Tang
Copy link
Owner

Thanks for the good suggestion! I have included this feature in the next release of the package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants