Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about block merging #39

Open
thangvubk opened this issue Apr 10, 2020 · 1 comment
Open

Question about block merging #39

thangvubk opened this issue Apr 10, 2020 · 1 comment

Comments

@thangvubk
Copy link

Thanks for your nice work. I have a question related to block-merging function.
In Blockmerging I don't quite understand the hard code at L#52:
if maxoverlapgroupcounts[i] < 7 and groupcounts[i] > 12.
What is 7 and 12 stand for? Could you please give me some intuition about this if statement.

@Yang7879
Copy link
Owner

hi @thangvubk, basically, it means if the new instance does not have more than 7 pts overlapped with previous instances, that new instance will be treated as a real new instance, otherwise, it will be regarded as the same instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants