Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application says that feed is invalid, while W3C says the inverse #170

Closed
metal3d opened this issue Jan 26, 2021 · 1 comment
Closed

Application says that feed is invalid, while W3C says the inverse #170

metal3d opened this issue Jan 26, 2021 · 1 comment
Labels
bug Something isn't working done Issue resolved.

Comments

@metal3d
Copy link

metal3d commented Jan 26, 2021

Describe the bug
A clear and concise description of what the bug is.
Opening my rss feed: https://www.metal3d.org/index.xml

image

But W3C says that it's ok:
https://validator.w3.org/feed/check.cgi?url=https%3A%2F%2Fwww.metal3d.org%2Findex.xml
image

To Reproduce
Steps to reproduce the behavior:
1.Add my feed
2. see error

Expected behavior
The feed should be displayed

Platform (please complete the following information):

  • OS: [e.g. Fedora 33]
  • Version [e.g. 0.9.0]
@yang991178 yang991178 added bug Something isn't working in progress Under development labels Jan 26, 2021
@yang991178
Copy link
Owner

It seems that the regular expression parsing XML encoding lacks a greedy modifier. Will fix in the next release.

XML_ENCODING_RE = /^<\?xml.+encoding="(.+)".*?\?>/i // problematic
XML_ENCODING_RE = /^<\?xml.+encoding="(.+?)".*?\?>/i // correct

This was referenced Jan 27, 2021
@yang991178 yang991178 added done Issue resolved. and removed in progress Under development labels Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working done Issue resolved.
Projects
None yet
Development

No branches or pull requests

2 participants