Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multilingual and English examples not working anymore #41

Closed
ik4Rus opened this issue Jul 10, 2021 · 5 comments
Closed

Multilingual and English examples not working anymore #41

ik4Rus opened this issue Jul 10, 2021 · 5 comments
Labels
help wanted Extra attention is needed

Comments

@ik4Rus
Copy link

ik4Rus commented Jul 10, 2021

Hi,

Thank you for the great repository.
For me especially the English models are interesting. Unfortunately your examples examples/aspect_term_extraction/extract_aspects.py and extract_aspects_multilingual.py do not work for me.

Expected behavior

The sample scripts extract_aspects.py and extract_aspects_multilingual.py can be executed.

Actual behavior

The get_checkpoint function doesn't find any model for English.

[...]
model_path = APCTrainedModelManager.get_checkpoint(checkpoint_name='English')
[...]
## Checkpoint:English is not found.

The reason is that there is no English language model in the checkpoints.json, that is being downloaded.

{ "0.8.8.0+":{
    "APC":{
        "chinese":{
        "id": "https://drive.google.com/file/d/12UPwGEOWcBToEmpiKAyeKTmXZ-38LDuo/view?usp=sharing",
        "description": "",
        "comment": ""
        }
    },
    "ATEPC":{
      "chinese":{
        "id": "https://drive.google.com/file/d/1LDCoYEhZLWt0pKsKflC3pOXUV3JMDT64/view?usp=sharing",
        "description": "",
        "comment": ""
      }
    }
}

I tried using download_pretrained_model to download an old model, but this one doesn't seem to be compatible anymore:

download_pretrained_model(task  ='APC', language = 'english', archive_path = '1AE2DC72vigxdAlYKjiV4_IfWsPUH7aX_')

It would be great if you could provide an English model for the new version of your package or explain how to run the examples.

Thank you 🙏
Ingo

@yangheng95
Copy link
Owner

yangheng95 commented Jul 11, 2021 via email

@yangheng95
Copy link
Owner

yangheng95 commented Jul 11, 2021

Hi,

Thank you for the great repository.
For me especially the English models are interesting. Unfortunately your examples examples/aspect_term_extraction/extract_aspects.py and extract_aspects_multilingual.py do not work for me.

Expected behavior

The sample scripts extract_aspects.py and extract_aspects_multilingual.py can be executed.

Actual behavior

The get_checkpoint function doesn't find any model for English.

[...]
model_path = APCTrainedModelManager.get_checkpoint(checkpoint_name='English')
[...]
## Checkpoint:English is not found.

The reason is that there is no English language model in the checkpoints.json, that is being downloaded.

{ "0.8.8.0+":{
    "APC":{
        "chinese":{
        "id": "https://drive.google.com/file/d/12UPwGEOWcBToEmpiKAyeKTmXZ-38LDuo/view?usp=sharing",
        "description": "",
        "comment": ""
        }
    },
    "ATEPC":{
      "chinese":{
        "id": "https://drive.google.com/file/d/1LDCoYEhZLWt0pKsKflC3pOXUV3JMDT64/view?usp=sharing",
        "description": "",
        "comment": ""
      }
    }
}

I tried using download_pretrained_model to download an old model, but this one doesn't seem to be compatible anymore:

download_pretrained_model(task  ='APC', language = 'english', archive_path = '1AE2DC72vigxdAlYKjiV4_IfWsPUH7aX_')

It would be great if you could provide an English model for the new version of your package or explain how to run the examples.

Thank you 🙏
Ingo

I just upload an English ATEPC checkpoint, you can try it.

@yangheng95 yangheng95 added the help wanted Extra attention is needed label Jul 11, 2021
@yangheng95
Copy link
Owner

And we call for sharing of the trained checkpoints due to the limitied computational resources. If somebody can help us, please see here.

@ik4Rus
Copy link
Author

ik4Rus commented Jul 11, 2021

Hi,
thanks for the message.
I might assist with training of new models. It would be great if you could email me (i.lange@mara.solutions). Then we could exchange which compute type is most suitable and what should be in the Dockerfile.
Best
Ingo

@yangheng95
Copy link
Owner

Hi,
thanks for the message.
I might assist with training of new models. It would be great if you could email me (i.lange@mara.solutions). Then we could exchange which compute type is most suitable and what should be in the Dockerfile.
Best
Ingo

That is great! I will email you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants