Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PasscodeLockViewController must have a successCallback #22

Closed
ziogaschr opened this issue Sep 19, 2015 · 3 comments
Closed

PasscodeLockViewController must have a successCallback #22

ziogaschr opened this issue Sep 19, 2015 · 3 comments

Comments

@ziogaschr
Copy link
Contributor

I have the need to set a successCallback to PasscodeLockViewController.
I see that there are two options:

  1. add a public var successCallback: ((lock: PasscodeLockType) -> Void)? which is then set as passcodeLockVC.successCallback
  2. make the passcodeLockVC a public var.

p.s.: Why the successCallback passes the lock: PasscodeLockType. Can you give me a good example? I might benefit from that.
@ziogaschr
Copy link
Contributor Author

I just found out something else. I would like to pass in PasscodeLockPresenter.presentPasscodeLock my own ViewController Class which inherits from PasscodeLockViewController. I do this, as I have to force some UI changes from code, that I can't apply in the .xib file.

@ziogaschr
Copy link
Contributor Author

I will add a PR soon

@ziogaschr
Copy link
Contributor Author

I am still working on it. I will include more things in the PR

ziogaschr pushed a commit to ziogaschr/SwiftPasscodeLock that referenced this issue Apr 5, 2017
@velikanov
Merge pull request yankodimitrov#22 from happylance/master
ba70b2c 
Fixed a security issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ziogaschr