Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Biometrics authentication presented even if !hasPasscode #38

Open
jovan90jovanovic opened this issue Feb 25, 2016 · 4 comments
Open

Biometrics authentication presented even if !hasPasscode #38

jovan90jovanovic opened this issue Feb 25, 2016 · 4 comments

Comments

@jovan90jovanovic
Copy link

Scenario:
When user logs in and set the passcode, then logs out and app deletes the passcode from defaults, if user closes and opens the app, biometrics authentication is presented. It can be canceled and user can continue using the app.

Fixable by:

private func authenticateWithBiometrics() {

    if !self.passcodeConfiguration.repository.hasPasscode { return }
    if passcodeConfiguration.shouldRequestTouchIDImmediately && passcodeLock.isTouchIDAllowed {

        passcodeLock.authenticateWithBiometrics()
    }
}
@jaytrixz
Copy link

jaytrixz commented Mar 9, 2016

Trying this workaround. I'm also having the same issue in the same scenario you describe above.

@ziogaschr
Copy link
Contributor

Nice catch @jovan90jovanovic.

I have fixed @velikanov's fork, which I hope to be merged soon with @yankodimitrov one, so as we can contribute to a single place, for this nice framework.

@jovan90jovanovic
Copy link
Author

@ziogaschr Thanks for fixing. Nice framework indeed.

@tovfigh
Copy link

tovfigh commented Aug 9, 2016

Hi, I have the same problem.

When I turn passcode off, clearEvents() is called and UIApplicationWillEnterForegroundNotification observer is removed, but for some reason when I close the app and open it again, appWillEnterForegroundHandler() is called even with the observer removed and so then authenticateWithBiometrics().

@jovan90jovanovic workaround fix biometrics authentication alertView but I think the real problem is still there.

Just wanted to add this if its in some way usefull.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants