Allow to skip resources using the GVK notation #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @atosatto , sorry for being a bit slow to follow with this PR. Is this linked to #84 ? I got thinking about the tests and now realise a good part of the diff is just reformatting 🙈 Thanks a lot for your contribution ❤️ Could you update the Readme and usage guidelines to make it clear how this would change the usage? 🙏 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is improving the
skiporrejectfunctionality allowing to provide the full GroupVersionKind encoding for resources to be skipped.The functionality is useful in scenarios in which specific versions of certain resources should always be rejected and/or to allow more fine-grained control of the skip logic.
Unlike the GKV encoding implemented in the upstream Kubernetes project, the APIVersion and Kind fields are separated by
/to allow the concatenation of multiple arguments by,.