[fix] propTypes: resolveSuperParameterPropsType: add null check

Fixes #2179.
jsx-eslint · Apr 10, 2019 · 60b4b31 · 60b4b31
1 parent eeb77f9
commit 60b4b31
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/lib/util/propTypes.js b/lib/util/propTypes.js
@@ -612,7 +612,7 @@ module.exports = function propTypesInstructions(context, components, utils) {
       annotation = annotation.typeAnnotation;
     }
 
-    if (annotation.type === 'GenericTypeAnnotation' && getInTypeScope(annotation.id.name)) {
+    if (annotation && annotation.type === 'GenericTypeAnnotation' && getInTypeScope(annotation.id.name)) {
       return getInTypeScope(annotation.id.name);
     }
     return annotation;

diff --git a/tests/lib/rules/prop-types.js b/tests/lib/rules/prop-types.js
@@ -1805,6 +1805,20 @@ ruleTester.run('prop-types', rule, {
           }
         }
       `,
+      settings: {react: {flowVersion: '0.52'}},
+      parser: 'babel-eslint'
+    }, {
+      code: `
+        type Props = {
+          foo: string,
+        };
+
+        class Bar extends React.Component<Props> {
+          render() {
+            return <div>{this.props.foo}</div>
+          }
+        }
+      `,
       settings: {react: {flowVersion: '0.53'}},
       parser: 'babel-eslint'
     }, {