Merge pull request #1504 from mrichmond/bugfix/no-typos-TypeError

Fix TypeError for undefined node in PropType.shape
jsx-eslint · Jan 3, 2018 · c23d395 · c23d395
2 parents a7bc91b + d9c36bf
commit c23d395
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 2 deletions.
diff --git a/lib/rules/no-typos.js b/lib/rules/no-typos.js
@@ -73,7 +73,7 @@ module.exports = {
     }
 
     function checkValidPropObject (node) {
-      if (node.type === 'ObjectExpression') {
+      if (node && node.type === 'ObjectExpression') {
         node.properties.forEach(prop => checkValidProp(prop.value));
       }
     }

diff --git a/tests/lib/rules/no-typos.js b/tests/lib/rules/no-typos.js
@@ -174,7 +174,7 @@ ruleTester.run('no-typos', rule, {
       const contextTypes = "CONTEXTTYPES"
       const childContextTypes = "CHILDCONTEXTTYPES"
       const defautProps = "DEFAULTPROPS"
-      
+
       class First extends React.Component {}
       First[propTypes] = {};
       First[contextTypes] = {};
@@ -338,6 +338,29 @@ ruleTester.run('no-typos', rule, {
    `,
     parser: 'babel-eslint',
     parserOptions: parserOptions
+  }, {
+    // ensure that an absent arg to PropTypes.shape does not crash
+    code: `class Component extends React.Component {};
+     Component.propTypes = {
+       a: PropTypes.shape(),
+     };
+     Component.contextTypes = {
+       a: PropTypes.shape(),
+     };
+    `,
+    parserOptions: parserOptions
+  }, {
+    // ensure that an absent arg to PropTypes.shape does not crash
+    code: `class Component extends React.Component {};
+     Component.propTypes = {
+       a: PropTypes.shape(),
+     };
+     Component.contextTypes = {
+       a: PropTypes.shape(),
+     };
+    `,
+    parser: 'babel-eslint',
+    parserOptions: parserOptions
   }, {
     code: `
       const fn = (err, res) => {