Fix require-render-return to not check stateless functions (fixes #550)

jsx-eslint · Apr 17, 2016 · d9d7963 · d9d7963
1 parent b8cac74
commit d9d7963
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/lib/rules/require-render-return.js b/lib/rules/require-render-return.js
@@ -10,7 +10,7 @@ var Components = require('../util/Components');
 // Rule Definition
 // ------------------------------------------------------------------------------
 
-module.exports = Components.detect(function(context, components) {
+module.exports = Components.detect(function(context, components, utils) {
 
   /**
    * Mark a return statement as present
@@ -44,7 +44,11 @@ module.exports = Components.detect(function(context, components) {
     'Program:exit': function() {
       var list = components.list();
       for (var component in list) {
-        if (!list.hasOwnProperty(component) || list[component].hasReturnStatement) {
+        if (
+          !list.hasOwnProperty(component) ||
+          list[component].hasReturnStatement ||
+          (!utils.isES5Component(list[component].node) && !utils.isES6Component(list[component].node))
+        ) {
           continue;
         }
         context.report({

diff --git a/tests/lib/rules/require-render-return.js b/tests/lib/rules/require-render-return.js
@@ -48,6 +48,14 @@ ruleTester.run('require-render-return', rule, {
       '});'
     ].join('\n'),
     parserOptions: parserOptions
+  }, {
+    // Stateless function
+    code: [
+      'function Hello() {',
+      '  return <div></div>;',
+      '}'
+    ].join('\n'),
+    parserOptions: parserOptions
   }, {
     // Return in a switch...case
     code: [