Merge pull request #1112 from ethanjgoldberg/method-annotations-are-n…

…ot-prop-types Fix required prop types for classes with annotated methods.
jsx-eslint · May 27, 2017 · dc03975 · dc03975
2 parents ccb213d + 6e8f543
commit dc03975
Show file tree

Hide file tree

Showing 2 changed files with 39 additions and 1 deletion.
diff --git a/lib/rules/prop-types.js b/lib/rules/prop-types.js
@@ -868,7 +868,12 @@ module.exports = {
 
       ArrowFunctionExpression: handleStatelessComponent,
 
-      FunctionExpression: handleStatelessComponent,
+      FunctionExpression: function(node) {
+        if (node.parent.type === 'MethodDefinition') {
+          return;
+        }
+        handleStatelessComponent(node);
+      },
 
       MemberExpression: function(node) {
         var type;

diff --git a/tests/lib/rules/prop-types.js b/tests/lib/rules/prop-types.js
@@ -1115,6 +1115,20 @@ ruleTester.run('prop-types', rule, {
         '}'
       ].join('\n'),
       parser: 'babel-eslint'
+    }, {
+      code: [
+        'type Props = {',
+        '  name: string,',
+        '};',
+        'class Hello extends React.Component {',
+        '  props: Props;',
+        '  render() {',
+        '    const {name} = this.props;',
+        '    return name;',
+        '  }',
+        '}'
+      ].join('\n'),
+      parser: 'babel-eslint'
     }, {
       code: [
         'Card.propTypes = {',
@@ -1405,6 +1419,25 @@ ruleTester.run('prop-types', rule, {
 
   invalid: [
     {
+      code: [
+        'type Props = {',
+        '  name: string,',
+        '};',
+        'class Hello extends React.Component {',
+        '  foo(props: Props) {}',
+        '  render() {',
+        '    return this.props.name;',
+        '  }',
+        '}'
+      ].join('\n'),
+      errors: [{
+        message: '\'name\' is missing in props validation',
+        line: 7,
+        column: 23,
+        type: 'Identifier'
+      }],
+      parser: 'babel-eslint'
+    }, {
       code: [
         'var Hello = createReactClass({',
         '  render: function() {',