Merge pull request #1611 from pfhayes/node.init

[Fix] `no-access-state-in-setstate`: Handle nodes without init
jsx-eslint · Dec 20, 2017 · f40b7b8 · f40b7b8
2 parents 9b8ea5e + bb34372
commit f40b7b8
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/lib/rules/no-access-state-in-setstate.js b/lib/rules/no-access-state-in-setstate.js
@@ -143,7 +143,7 @@ module.exports = {
       },
 
       ObjectPattern(node) {
-        const isDerivedFromThis = node.parent.init.type === 'ThisExpression';
+        const isDerivedFromThis = node.parent.init && node.parent.init.type === 'ThisExpression';
         node.properties.forEach(property => {
           if (property.key.name === 'state' && isDerivedFromThis) {
             vars.push({

diff --git a/tests/lib/rules/no-access-state-in-setstate.js b/tests/lib/rules/no-access-state-in-setstate.js
@@ -75,6 +75,13 @@ ruleTester.run('no-access-state-in-setstate', rule, {
       '});'
     ].join('\n'),
     parserOptions: parserOptions
+  }, {
+    // https://github.com/yannickcr/eslint-plugin-react/pull/1611
+    code: `
+      function testFunction({a, b}) {
+      };
+    `,
+    parserOptions: parserOptions
   }],
 
   invalid: [{