Fix required prop types for classes with annotated methods. #1112
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
react/prop-types
rule incorrectly considers flow typeannotations on class methods with arguments named
props
asprop type declarations for the class, even though flow itself
gives them no such weight.
When a react component is defined as a class extending
React.Component
,and it defines a method that takes an annotated argument named
props
,then, even though flow still thinks the props have
any
type, theprop-types
rule will not produce 'missing in props validation' errors.A pattern that gets used a lot in React components is as follows:
which makes this especially nefarious.