Small document improvements #1199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
May 16, 2017
| @@ -6,11 +6,12 @@ Ensure correct position of the first property. | |||
|
|
|||
| ## Rule Details | |||
|
|
|||
| This rule checks whether the first property of all JSX elements is correctly placed. There are three possible configurations: | |||
| This rule checks whether the first property of all JSX elements is correctly placed. There are four possible configurations: | |||
There was a problem hiding this comment.
maybe instead of enumerating "four", we should just say "These are the possible configurations:" and then nobody needs to update it in the future?
There was a problem hiding this comment.
Got it, I'll update it.
| * `always`: The first property should always be placed on a new line. | ||
| * `never` : The first property should never be placed on a new line, e.g. should always be on the same line as the Component opening tag. | ||
| * `multiline`: The first property should always be placed on a new line when the JSX tag takes up multiple lines. | ||
| * `multiline-multiprop`: The first property should always be placed on a new line if the JSX tag takes up multiple lines and there are multiple properties. `default` | ||
| * `multiline-multiprop`: The first property should always be placed on a new line if the JSX tag takes up multiple lines and there are multiple properties. This is `default` value. |
|
After making the updates, please rebase this down to a single commit :-) thanks! |
Clarify options and examples Add missing changes Apply suggestion Merge remote-tracking branch 'preco21/docs-improvement' into docs-improvement
|
@ljharb Here we go :) Please review the changes if there are any other changes needed. |
yannickcr
approved these changes
May 16, 2017
ljharb
approved these changes
May 16, 2017
1 task
This was referenced Sep 22, 2018
This was referenced Oct 25, 2018
1 task
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jsx-first-prop-new-line.md.jsx-wrap-multilines.md.