sort-comp: static defaultProps must be placed under componentWillUnmount()

[andrevinsky]

For some reason, the ES6 class composition for React isn't taken into account.

For all obvious reasons, while this is supposed to be the right sort order..

class AccountInfo extends Component {

  static propTypes = {
    accountId: PropTypes.string.isRequired
  };

  static defaultProps = {
    accountId: ''
  };

..a warning shows that says:
warning defaultProps must be placed after componentWillUnmount react/sort-comp

[mathieumg]

I'm curious, if you manually add defaultProps after propTypes in the lifecycle configuration, does it solve it? If so, it could be added at the same time as constructor is, see: #97 (comment)

[andrevinsky]

I edited .eslitrc to contain this line:

    "react/sort-comp": [1,
      {
        "order": [
          "constructor",
          "lifecycle",
          "everything-else",
          "render"
        ]
      }],

Still, I get this:
28:2 warning defaultProps must be placed after componentWillUnmount react/sort-comp
for the ..

class AccountInfo extends Component {

  static propTypes = {
    accountId: PropTypes.string.isRequired
  };

  //noinspection Eslint
  static defaultProps = {
    accountId: ''
  };

[andrevinsky]

And.. I am still getting this error regarding the constuctor placement:

CreateAccount.js
   36:2   warning  constructor must be placed after componentWillUnmount  react/sort-comp
  134:16  warning  Empty components are self-closing                      react/self-closing-comp
  139:16  warning  Empty components are self-closing                      react/self-closing-comp

[yannickcr]

ES6 methods are not set in the default lifecycle configuration (yet). This should be fixed when I'll work on #97

So, for now you can set up a custom lifecycle configuration in your .eslintrc:

...
"react/sort-comp": [1, {
  "groups": {
    "lifecyle": [
      "constructor",
      "displayName",
      "propTypes",
      "contextTypes",
      "childContextTypes",
      "statics",
      "defaultProps",
      "getChildContext",
      "componentWillMount",
      "componentDidMount",
      "componentWillReceiveProps",
      "shouldComponentUpdate",
      "componentWillUpdate",
      "componentDidUpdate",
      "componentWillUnmount"
    ]
  }
}]
...

You can find more informations about this rule configuration settings in the documentation.