Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

peerDependency causing install to fail with eslint@1.0.0-rc-1 #154

Closed
feross opened this issue Jul 15, 2015 · 7 comments
Closed

peerDependency causing install to fail with eslint@1.0.0-rc-1 #154

feross opened this issue Jul 15, 2015 · 7 comments

Comments

@feross
Copy link

feross commented Jul 15, 2015

Eslint just released version 1.0.0-rc-1 which doesn't work with this plugin.

Can we switch the peerDependency to *? Right now I'm in dependency hell. :(

@yannickcr
Copy link
Member

Ok to switch to *

@BerkeleyTrue
Copy link

What about removing peer deps entirely. NPM 3 is coming out and does away with all that non-sense in favor or dedupe's and flat trees.

@yannickcr
Copy link
Member

Actually I'd prefer to keep it until the final version of npm 3 is released.

@yannickcr
Copy link
Member

After testing, * does not seems to accept pre-release versions since npm 2.

I switched to >=0.8.0 || ~1.0.0-rc-0, it should do the trick.

@feross
Copy link
Author

feross commented Jul 15, 2015

Thanks!
On Wed, Jul 15, 2015 at 4:01 PM Yannick Croissant notifications@github.com
wrote:

After testing, * does not seems to accept pre-release versions since npm
2.

I switched to >=0.8.0 || ~1.0.0-rc-0, it should do the trick.


Reply to this email directly or view it on GitHub
#154 (comment)
.

@doctyper
Copy link

I'm still seeing this issue when trying to install eslint@^1.0.0-rc-1 + eslint-plugin-react@^2.7.1. Here are my dependencies for reference:

  "dependencies": {
    "eslint": "^1.0.0-rc-1",
    "eslint-plugin-react": "^2.7.1"
  },
  "peerDependencies": {
    "eslint-plugin-react": ">=2.x",
    "eslint": ">=0.23.0"
  }

And the error:

❯ npm install
npm ERR! Darwin 13.4.0
npm ERR! argv "node" "npm" "install"
npm ERR! node v0.12.2
npm ERR! npm  v2.13.0
npm ERR! code EPEERINVALID

npm ERR! peerinvalid The package eslint@1.0.0-rc-1 does not satisfy its siblings' peerDependencies requirements!
npm ERR! peerinvalid Peer eslint-plugin-react@2.7.1 wants eslint@>=0.8.0 || ~1.0.0-rc-0

@doctyper
Copy link

Please ignore, I immediately saw my problem :). Needed to update my eslint in peerDependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants