-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error in prop-types rule: key is undefined #269
Comments
It would be a great help for us if you can track down the code responsible for the crash, maybe by running ESLint on one directory at a time until you find the file that trigger this error ? |
So the problem seems to be specifically related to the rest spread feature we use in our JSX files:
Works fine. But this:
Results in the TypeError as shown in my first post. I've seen some other issues (eslint/eslint#3271) regarding the However, I'm pretty sure the |
I was not able to reproduce the error, but it should be fixed in If it is not the case, re-open this issue and add the complete code sample that trigger the crash. |
Hey, sorry to get back at you this late. I was able to reproduce this bug here: Lapixx/a30830afe8408756d254 Running eslint 1.5.1 and eslint-plugin-react 3.8.0 |
Thanks for your test case, I can reproduce it now. |
We just encountered an error in the
prop-types
rule while ESLinting a JSX file. I'm unable to share the full source, but will try to pinpoint the part where the rule fails exactly.In the meantime, this is the full stack trace:
Also, ESLint exited with code 0 in the end, which to me looks not really desirable if one of the rules fails, although I assume that's more of an issue of ESLint itself.
The text was updated successfully, but these errors were encountered: