breaks with ESlint 1.10.0

[BerkeleyTrue]

Breaks with eslint 1.10.0
Runs fine with eslint 1.9.0

eslint-plugin-react 3.9.0
node 4.2.1
npm 2.14.7

[lukekarrys]

It looks like a performance improvement PR (eslint/eslint#4428) is now freezing context in a few places which creates this error.

If I run the tests with the following lines commented out in eslint, the tests pass:

• https://github.com/eslint/eslint/blob/be2c000ad0c1ee5ebd04e26e89678cd0ba659201/lib/testers/rule-tester.js#L293
• https://github.com/eslint/eslint/blob/be2c000ad0c1ee5ebd04e26e89678cd0ba659201/lib/rule-context.js#L85

It seems like this line is the only place mutating context, but being unfamiliar with eslint plugins I'm not sure what changes need to be made.

Edit: created #324 with a simple fix.

[jayphelps]

Seeing this as well. Adding this simply for SEO:

Error while loading rule 'react/no-multi-comp': Can't add property react, object is not extensible

[machadogj]

@jayphelps +1, I ended up here while trying to report the issue!

[ghost]

Hi I have lastest version of plugin and I have same issue

Error while loading rule 'react/no-multi-comp': Can't add property react, object is not extensible
TypeError: Error while loading rule 'react/no-multi-comp': Can't add property react, object is not extensible
    at Function.componentRule (/usr/lib/node_modules/eslint-plugin-react/lib/util/Components.js:111:17)
    at /usr/lib/node_modules/eslint/lib/eslint.js:692:28
    at Array.forEach (native)
    at EventEmitter.module.exports.api.verify (/usr/lib/node_modules/eslint/lib/eslint.js:671:16)
    at processText (/usr/lib/node_modules/eslint/lib/cli-engine.js:230:27)
    at CLIEngine.executeOnText (/usr/lib/node_modules/eslint/lib/cli-engine.js:686:26)
    at Object.cli.execute (/usr/lib/node_modules/eslint/lib/cli.js:162:36)
    at /usr/lib/node_modules/eslint/bin/eslint.js:41:28
    at ConcatStream.<anonymous> (/usr/lib/node_modules/eslint/node_modules/concat-stream/index.js:36:43)
    at emitNone (events.js:72:20)

[nzakas]

FWIW, ESLint pushed out an update - we unintentionally introduced this breaking change (well, we intentionally made the change, just didn't realize it would break anything). We won't reintroduce the change until ESLint v2.0.0 so as to avoid any further compatibility issues. We're also going to look into adding eslint-plugin-react to our automated testing so we can find compatibility issues faster.

[yannickcr]

Great, I also published eslint-plugin-react 3.10.0 with the fix to stop extending the context object. So everything should be fine now :)

[machadogj]

Awesome work guys!

On Nov 20, 2015, at 8:39 PM, paulmartinezatdocker notifications@github.com wrote:

Just tested the latest version and my issue has now been resolved.

Thanks guys!

—
Reply to this email directly or view it on GitHub.

[langri-sha]

Hey, I woke up this morning and everything works! Thank you.