Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jsx-key to recommended configuration #750

Closed
lencioni opened this issue Aug 7, 2016 · 1 comment
Closed

Add jsx-key to recommended configuration #750

lencioni opened this issue Aug 7, 2016 · 1 comment
Assignees
Milestone

Comments

@lencioni
Copy link
Collaborator

lencioni commented Aug 7, 2016

The jsx-key rule ensures that JSX has a key prop when in an array or iterator. If you don't use a key prop here, React will issue warnings. Given that this is a runtime warning, it seems reasonable to add this rule to the recommended configuration. What do folks think?

I'm adding this to the 7.0.0 milestone so we don't forget to do this for our next major version bump.

@lencioni lencioni added this to the 7.0.0 milestone Aug 7, 2016
@ljharb
Copy link
Member

ljharb commented Aug 8, 2016

SGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants