Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transform variables #1277

Merged
merged 2 commits into from
Jun 27, 2017
Merged

Transform variables #1277

merged 2 commits into from
Jun 27, 2017

Conversation

dfilipidisz
Copy link
Contributor

Continue work on #1240.

Transformed var statements to const and let, added eslint rules to enforce them.

Not included:

  • Examples in docs not updated
  • Test code blocks not updated

If there is anything I can do to make these large scale changes easier to handle, please let me know!

@ljharb
Copy link
Member

ljharb commented Jun 27, 2017

Was this done manually, or solely with eslint --fix?

@dfilipidisz
Copy link
Contributor Author

First I ran eslint ---fix than I fixed the ~15 cases where it couldn't do it by itself.

lencioni
lencioni approved these changes Jun 27, 2017
View reviewed changes
Copy link
Collaborator

@lencioni lencioni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Moving forward it would be preferable to put all of the automated changes in their own commit and follow up with commits that contain only manual changes. That would make it easier to review.

@dfilipidisz
Copy link
Contributor Author

Okay, I'll definitely do that in the future! Thanks for guiding me along this, I don't have much experience in open source :)

@lencioni lencioni merged commit d672588 into jsx-eslint:master Jun 27, 2017
@lencioni
Copy link
Collaborator

I don't have much experience in open source :)

You are doing a great job! Keep it up 💃

@dfilipidisz dfilipidisz deleted the transform-variables branch June 27, 2017 17:35
lencioni added a commit that referenced this pull request Jun 27, 2017
@lencioni
Fix linting errors
f67f4a9 
In #1277 we enabled some new eslint rules, but the branch hadn't been
freshly rebased, so a few failures snuck in. I fixed these by running

```sh
npm run lint -- --fix
```
@dependencies dependencies bot mentioned this pull request Aug 25, 2017
Open
@renovate renovate bot mentioned this pull request Feb 2, 2018
Open
1 task
This was referenced Sep 22, 2018
Closed
Closed
Open
Open
Open
Open
Open
This was referenced Oct 25, 2018
Merged
Open
@renovate renovate bot mentioned this pull request Nov 7, 2018
Merged
@renovate renovate bot mentioned this pull request Nov 23, 2018
Open
1 task
@renovate renovate bot mentioned this pull request Dec 5, 2018
Closed
1 task
@mesosphere-web mesosphere-web mentioned this pull request Dec 19, 2018
Closed
1 task
This was referenced Jan 8, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lencioni lencioni lencioni approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dfilipidisz @ljharb @lencioni