Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support createClass in no-typos #1828

Merged
merged 1 commit into from Dec 28, 2018

Conversation

@alexzherdev
Copy link
Contributor

alexzherdev commented Jun 15, 2018

Resolves #1721

Also added some more tests for good measure.
Not sure about the exact message for an ES5 component, but mentioning static class property didn't make sense.

Resolves #1721
@ljharb
ljharb approved these changes Jun 16, 2018
if (propertyName === 'propTypes' || propertyName === 'contextTypes' || propertyName === 'childContextTypes') {
checkValidPropObject(node);
}
STATIC_CLASS_PROPERTIES.forEach(CLASS_PROP => {
if (propertyName && CLASS_PROP.toLowerCase() === propertyName.toLowerCase() && CLASS_PROP !== propertyName) {
const message = isClassProperty
? 'Typo in static class property declaration'

This comment has been minimized.

Copy link
@ljharb

ljharb Jun 16, 2018

Collaborator

i think it's fine to have different messages, but "static class property" is a conceptual term prior to the feature landing in the language, so i think that'd be reasonable.

@alexzherdev alexzherdev force-pushed the alexzherdev:1721-no-typos-create-class branch from 07232ad to d641900 Sep 8, 2018
@ljharb ljharb requested review from EvHaus and yannickcr Dec 27, 2018
@EvHaus
EvHaus approved these changes Dec 28, 2018
Copy link
Collaborator

EvHaus left a comment

LGTM.

@ljharb ljharb force-pushed the alexzherdev:1721-no-typos-create-class branch from d641900 to 7b70462 Dec 28, 2018
@ljharb ljharb merged commit d2b5b73 into yannickcr:master Dec 28, 2018
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.004%) to 97.474%
Details
@alexzherdev alexzherdev deleted the alexzherdev:1721-no-typos-create-class branch Dec 28, 2018
@renovate renovate bot mentioned this pull request Dec 28, 2018
0 of 1 task complete
@renovate-bot renovate-bot mentioned this pull request Dec 28, 2018
0 of 1 task complete
This was referenced Dec 28, 2018
This was referenced Jan 4, 2019
@ibf-renovate ibf-renovate mentioned this pull request Jan 12, 2019
0 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.