Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added shared settings info, React version default note fix for #2169 #2180

Merged
merged 1 commit into from Mar 6, 2019

Conversation

Projects
None yet
2 participants
@samsch
Copy link
Contributor

samsch commented Feb 27, 2019

The link to the eslint docs should be enough to clear confusion on where "settings" goes.

Initially I thought I could add the same note to flowVersion, but that config is set to throw if tested for and missing, so there isn't a default value.

@ljharb

ljharb approved these changes Mar 6, 2019

Copy link
Collaborator

ljharb left a comment

Thanks

@ljharb ljharb added the documentation label Mar 6, 2019

@ljharb ljharb merged commit b7f0b02 into yannickcr:master Mar 6, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 97.513%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.