Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find target={'_blank'} expressions #2451

merged 1 commit into from Oct 8, 2019


Copy link

@timkraut timkraut commented Oct 7, 2019

The jsx/no-target-blank rule does not detect the _blank value if written as an expression containing a string (such as target={'_blank'}). This PR fixes that.

ljharb approved these changes Oct 8, 2019
Copy link

@ljharb ljharb left a comment

I'm going to call this a minor, because it's a bugfix, but it will potentially result in more warnings for some.

@ljharb ljharb force-pushed the timkraut:find-target-blank-in-expressions branch from b3957f6 to 03bdefc Oct 8, 2019
@ljharb ljharb merged commit 03bdefc into yannickcr:master Oct 8, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
coverage/coveralls Coverage increased (+0.008%) to 97.562%
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants