Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(no-target-blank): Configure noreferrer requirement #2478

Merged

Conversation

@eps1lon
Copy link
Contributor

eps1lon commented Oct 30, 2019

Allows <a href="foobar" target="_blank" rel="noopener"></a> if the rule is configured with allowReferrer for links where we want the referrer for tracking. For rationale see #2054 (comment).

referrer is not a specified link type so I'd rather not introduce this magic-word for this rule.

See #776 (can be closed with this change?) and #2054

@ljharb
ljharb approved these changes Nov 29, 2019
@ljharb ljharb added the enhancement label Nov 29, 2019
@ljharb ljharb force-pushed the eps1lon:feat/no-target-blank/explicit-referrer branch from ef4ef2a to d3b5d71 Nov 29, 2019
@ljharb ljharb merged commit d3b5d71 into yannickcr:master Nov 29, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.002%) to 97.513%
Details
@eps1lon eps1lon deleted the eps1lon:feat/no-target-blank/explicit-referrer branch Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.