-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] boolean-prop-naming
: add check for typescript "boolean" type
#2930
Conversation
b8d3d5c
to
ae5ace5
Compare
(note, the new tests weren't actually running since |
boolean-prop-naming
: add check for typescript "boolean" typeboolean-prop-naming
: add check for typescript "boolean" type
that's weird, because it did run locally using this
|
@vedadeepta the tests completed, but weren't actually running, because |
This is the output i get when i run the tests without concat on this branch using the command Also i don't think the last test on the master branch for
The last one should fail but it does not. It also shows "61 passing" (+ no failures reported) instead of 62 as in the screenshot above. The last test is completely omitted on master. I think there is something wrong with parser.TS function. it just returns the first object most probably. |
I'll make some changes so it's harder to misuse. |
Thanks for looking into it. |
Overview of change:
Add a check for typescript boolean type without the need to explicitly define react PropTypes.
Will throw a linting error for the above code.