jsx-pascal-case #306
Merged
jsx-pascal-case #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| ## When Not To Use It | ||
|
|
||
| If you are not using JSX, or if you don't want your JSX components defined and referenced in PascalCase. |
There was a problem hiding this comment.
React will only work if user-land components are defined in PascalCase, otherwise it converts them to strings:
<foo />
<Foo />
becomes
React.createElement("foo", null)
React.createElement(Foo, null)
so perhaps this should just say
If you are not using JSX.
There was a problem hiding this comment.
Good point, updated
|
Ok for me. Like @Daniel15 said, can you set the rules in alphabetical order in the list? Then squash your commits? Thanks. |
jakemmarsh
force-pushed
the
jsx-pascal-case
branch
from
843cebf
to
9d07f1d
Compare
|
Fixed alphabetical order and squashed commits @yannickcr |
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new rule to enforce PascalCase for user-defined JSX components