allow es6 class rule to be configured to discourage usage as well #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why not. Maybe I'll rename this rule in next major version to be more explicit about the different styles. |
yannickcr
added a commit
that referenced
this pull request
Dec 13, 2015
Add never option to prefer-es6-class rule
|
Documentation on the rule page needs an update |
|
Suggestion: in the nitpicking matter of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't change the default behavior, but allows you to specify 'never' as an option that recommends createClass over using es6 classes.
The argument for switching is still a little murky. In the meantime its nice to be able to force it in either case.