Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a note about the recommended configuration at the bottom of the configuration section. #462

Merged
merged 1 commit into from
Feb 27, 2016

Conversation

thaggie
Copy link
Contributor

@thaggie thaggie commented Feb 23, 2016

Rather than moving the recommended configuration I've added a link to it and specifically called out the issue I had as without that rule it will always fail.

@yannickcr
Copy link
Member

Thanks. Can you squash your commits ?

…point people to the recommended rules.

The example of the recommended rules leaves in eslint's recommended rules as that's probably what people will want to do..
@thaggie
Copy link
Contributor Author

thaggie commented Feb 24, 2016

Done

yannickcr added a commit that referenced this pull request Feb 27, 2016
Added a note about the recommended configuration at the bottom of the configuration section.
@yannickcr yannickcr merged commit a9fc4ad into jsx-eslint:master Feb 27, 2016
@yannickcr
Copy link
Member

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants