Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use weakSelf.builder.readerView #171

Open
smarkars opened this issue May 6, 2019 · 1 comment
Open

Use weakSelf.builder.readerView #171

smarkars opened this issue May 6, 2019 · 1 comment

Comments

@smarkars
Copy link

smarkars commented May 6, 2019

Thanks for the wonderful library.
I faced a retain cycle. I'm not sure its just for me.

codeReader.didFindCode & codeReader.didFailDecoding builder should be accessed via weakSelf. Like weakSelf.builder to avoid retain cycles.
@dnguyen07
Copy link

Hi, i have an issue with the "didfindcode" when i expose 2 buttons with 2 closure in the coordinator method, only the first one is called, not the second one from the other button... Did u integrate it in swiftui?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dnguyen07 @smarkars